1
2
3
4
5 package work
6
7 import (
8 "os"
9 "strings"
10 "testing"
11 )
12
13 var goodCompilerFlags = [][]string{
14 {"-DFOO"},
15 {"-Dfoo=bar"},
16 {"-Ufoo"},
17 {"-Ufoo1"},
18 {"-F/Qt"},
19 {"-F", "/Qt"},
20 {"-I/"},
21 {"-I/etc/passwd"},
22 {"-I."},
23 {"-O"},
24 {"-O2"},
25 {"-Osmall"},
26 {"-W"},
27 {"-Wall"},
28 {"-Wp,-Dfoo=bar"},
29 {"-Wp,-Ufoo"},
30 {"-Wp,-Dfoo1"},
31 {"-Wp,-Ufoo1"},
32 {"-flto"},
33 {"-fobjc-arc"},
34 {"-fno-objc-arc"},
35 {"-fomit-frame-pointer"},
36 {"-fno-omit-frame-pointer"},
37 {"-fpic"},
38 {"-fno-pic"},
39 {"-fPIC"},
40 {"-fno-PIC"},
41 {"-fpie"},
42 {"-fno-pie"},
43 {"-fPIE"},
44 {"-fno-PIE"},
45 {"-fsplit-stack"},
46 {"-fno-split-stack"},
47 {"-fstack-xxx"},
48 {"-fno-stack-xxx"},
49 {"-fsanitize=hands"},
50 {"-ftls-model=local-dynamic"},
51 {"-g"},
52 {"-ggdb"},
53 {"-march=souza"},
54 {"-mcmodel=medium"},
55 {"-mcpu=123"},
56 {"-mfpu=123"},
57 {"-mlarge-data-threshold=16"},
58 {"-mtune=happybirthday"},
59 {"-mstack-overflow"},
60 {"-mno-stack-overflow"},
61 {"-mmacosx-version"},
62 {"-mnop-fun-dllimport"},
63 {"-pthread"},
64 {"-std=c99"},
65 {"-xc"},
66 {"-D", "FOO"},
67 {"-D", "foo=bar"},
68 {"-I", "."},
69 {"-I", "/etc/passwd"},
70 {"-I", "世界"},
71 {"-I", "=/usr/include/libxml2"},
72 {"-I", "dir"},
73 {"-I", "$SYSROOT/dir"},
74 {"-isystem", "/usr/include/mozjs-68"},
75 {"-include", "/usr/include/mozjs-68/RequiredDefines.h"},
76 {"-framework", "Chocolate"},
77 {"-x", "c"},
78 {"-v"},
79 }
80
81 var badCompilerFlags = [][]string{
82 {"-D@X"},
83 {"-D-X"},
84 {"-Ufoo=bar"},
85 {"-F@dir"},
86 {"-F-dir"},
87 {"-I@dir"},
88 {"-I-dir"},
89 {"-O@1"},
90 {"-Wa,-foo"},
91 {"-W@foo"},
92 {"-Wp,-DX,-D@X"},
93 {"-Wp,-UX,-U@X"},
94 {"-g@gdb"},
95 {"-g-gdb"},
96 {"-march=@dawn"},
97 {"-march=-dawn"},
98 {"-mcmodel=@model"},
99 {"-mlarge-data-threshold=@12"},
100 {"-std=@c99"},
101 {"-std=-c99"},
102 {"-x@c"},
103 {"-x-c"},
104 {"-D", "@foo"},
105 {"-D", "-foo"},
106 {"-I", "@foo"},
107 {"-I", "-foo"},
108 {"-I", "=@obj"},
109 {"-include", "@foo"},
110 {"-framework", "-Caffeine"},
111 {"-framework", "@Home"},
112 {"-x", "--c"},
113 {"-x", "@obj"},
114 }
115
116 func TestCheckCompilerFlags(t *testing.T) {
117 for _, f := range goodCompilerFlags {
118 if err := checkCompilerFlags("test", "test", f); err != nil {
119 t.Errorf("unexpected error for %q: %v", f, err)
120 }
121 }
122 for _, f := range badCompilerFlags {
123 if err := checkCompilerFlags("test", "test", f); err == nil {
124 t.Errorf("missing error for %q", f)
125 }
126 }
127 }
128
129 var goodLinkerFlags = [][]string{
130 {"-Fbar"},
131 {"-lbar"},
132 {"-Lbar"},
133 {"-fpic"},
134 {"-fno-pic"},
135 {"-fPIC"},
136 {"-fno-PIC"},
137 {"-fpie"},
138 {"-fno-pie"},
139 {"-fPIE"},
140 {"-fno-PIE"},
141 {"-fsanitize=hands"},
142 {"-g"},
143 {"-ggdb"},
144 {"-march=souza"},
145 {"-mcpu=123"},
146 {"-mfpu=123"},
147 {"-mtune=happybirthday"},
148 {"-pic"},
149 {"-pthread"},
150 {"-Wl,--hash-style=both"},
151 {"-Wl,-rpath,foo"},
152 {"-Wl,-rpath,$ORIGIN/foo"},
153 {"-Wl,-R", "/foo"},
154 {"-Wl,-R", "foo"},
155 {"-Wl,-R,foo"},
156 {"-Wl,--just-symbols=foo"},
157 {"-Wl,--just-symbols,foo"},
158 {"-Wl,--warn-error"},
159 {"-Wl,--no-warn-error"},
160 {"foo.so"},
161 {"_世界.dll"},
162 {"./x.o"},
163 {"libcgosotest.dylib"},
164 {"-F", "framework"},
165 {"-l", "."},
166 {"-l", "/etc/passwd"},
167 {"-l", "世界"},
168 {"-L", "framework"},
169 {"-framework", "Chocolate"},
170 {"-v"},
171 {"-Wl,-sectcreate,__TEXT,__info_plist,${SRCDIR}/Info.plist"},
172 {"-Wl,-framework", "-Wl,Chocolate"},
173 {"-Wl,-framework,Chocolate"},
174 {"-Wl,-unresolved-symbols=ignore-all"},
175 {"-Wl,-z,relro"},
176 {"-Wl,-z,relro,-z,now"},
177 {"-Wl,-z,now"},
178 {"-Wl,-z,noexecstack"},
179 {"libcgotbdtest.tbd"},
180 {"./libcgotbdtest.tbd"},
181 {"-Wl,--push-state"},
182 {"-Wl,--pop-state"},
183 {"-Wl,--push-state,--as-needed"},
184 {"-Wl,--push-state,--no-as-needed,-Bstatic"},
185 {"-Wl,--just-symbols,."},
186 {"-Wl,-framework,."},
187 {"-Wl,-rpath,."},
188 {"-Wl,-rpath-link,."},
189 {"-Wl,-sectcreate,.,.,."},
190 {"-Wl,-syslibroot,."},
191 {"-Wl,-undefined,."},
192 }
193
194 var badLinkerFlags = [][]string{
195 {"-DFOO"},
196 {"-Dfoo=bar"},
197 {"-W"},
198 {"-Wall"},
199 {"-fobjc-arc"},
200 {"-fno-objc-arc"},
201 {"-fomit-frame-pointer"},
202 {"-fno-omit-frame-pointer"},
203 {"-fsplit-stack"},
204 {"-fno-split-stack"},
205 {"-fstack-xxx"},
206 {"-fno-stack-xxx"},
207 {"-mstack-overflow"},
208 {"-mno-stack-overflow"},
209 {"-mnop-fun-dllimport"},
210 {"-std=c99"},
211 {"-xc"},
212 {"-D", "FOO"},
213 {"-D", "foo=bar"},
214 {"-I", "FOO"},
215 {"-L", "@foo"},
216 {"-L", "-foo"},
217 {"-x", "c"},
218 {"-D@X"},
219 {"-D-X"},
220 {"-I@dir"},
221 {"-I-dir"},
222 {"-O@1"},
223 {"-Wa,-foo"},
224 {"-W@foo"},
225 {"-g@gdb"},
226 {"-g-gdb"},
227 {"-march=@dawn"},
228 {"-march=-dawn"},
229 {"-std=@c99"},
230 {"-std=-c99"},
231 {"-x@c"},
232 {"-x-c"},
233 {"-D", "@foo"},
234 {"-D", "-foo"},
235 {"-I", "@foo"},
236 {"-I", "-foo"},
237 {"-l", "@foo"},
238 {"-l", "-foo"},
239 {"-framework", "-Caffeine"},
240 {"-framework", "@Home"},
241 {"-Wl,-framework,-Caffeine"},
242 {"-Wl,-framework", "-Wl,@Home"},
243 {"-Wl,-framework", "@Home"},
244 {"-Wl,-framework,Chocolate,@Home"},
245 {"-Wl,--hash-style=foo"},
246 {"-x", "--c"},
247 {"-x", "@obj"},
248 {"-Wl,-rpath,@foo"},
249 {"-Wl,-R,foo,bar"},
250 {"-Wl,-R,@foo"},
251 {"-Wl,--just-symbols,@foo"},
252 {"../x.o"},
253 {"-Wl,-R,"},
254 {"-Wl,-O"},
255 {"-Wl,-e="},
256 {"-Wl,-e,"},
257 {"-Wl,-R,-flag"},
258 {"-Wl,--push-state,"},
259 {"-Wl,--push-state,@foo"},
260 {"-fplugin=./-Wl,--push-state,-R.so"},
261 {"./-Wl,--push-state,-R.c"},
262 }
263
264 func TestCheckLinkerFlags(t *testing.T) {
265 for _, f := range goodLinkerFlags {
266 if err := checkLinkerFlags("test", "test", f); err != nil {
267 t.Errorf("unexpected error for %q: %v", f, err)
268 }
269 }
270 for _, f := range badLinkerFlags {
271 if err := checkLinkerFlags("test", "test", f); err == nil {
272 t.Errorf("missing error for %q", f)
273 }
274 }
275 }
276
277 func TestCheckFlagAllowDisallow(t *testing.T) {
278 if err := checkCompilerFlags("TEST", "test", []string{"-disallow"}); err == nil {
279 t.Fatalf("missing error for -disallow")
280 }
281 os.Setenv("CGO_TEST_ALLOW", "-disallo")
282 if err := checkCompilerFlags("TEST", "test", []string{"-disallow"}); err == nil {
283 t.Fatalf("missing error for -disallow with CGO_TEST_ALLOW=-disallo")
284 }
285 os.Setenv("CGO_TEST_ALLOW", "-disallow")
286 if err := checkCompilerFlags("TEST", "test", []string{"-disallow"}); err != nil {
287 t.Fatalf("unexpected error for -disallow with CGO_TEST_ALLOW=-disallow: %v", err)
288 }
289 os.Unsetenv("CGO_TEST_ALLOW")
290
291 if err := checkCompilerFlags("TEST", "test", []string{"-Wall"}); err != nil {
292 t.Fatalf("unexpected error for -Wall: %v", err)
293 }
294 os.Setenv("CGO_TEST_DISALLOW", "-Wall")
295 if err := checkCompilerFlags("TEST", "test", []string{"-Wall"}); err == nil {
296 t.Fatalf("missing error for -Wall with CGO_TEST_DISALLOW=-Wall")
297 }
298 os.Setenv("CGO_TEST_ALLOW", "-Wall")
299 if err := checkCompilerFlags("TEST", "test", []string{"-Wall"}); err == nil {
300 t.Fatalf("missing error for -Wall with CGO_TEST_DISALLOW=-Wall and CGO_TEST_ALLOW=-Wall")
301 }
302
303 os.Setenv("CGO_TEST_ALLOW", "-fplugin.*")
304 os.Setenv("CGO_TEST_DISALLOW", "-fplugin=lint.so")
305 if err := checkCompilerFlags("TEST", "test", []string{"-fplugin=faster.so"}); err != nil {
306 t.Fatalf("unexpected error for -fplugin=faster.so: %v", err)
307 }
308 if err := checkCompilerFlags("TEST", "test", []string{"-fplugin=lint.so"}); err == nil {
309 t.Fatalf("missing error for -fplugin=lint.so: %v", err)
310 }
311 }
312
313 func TestCheckCompilerFlagsForInternalLink(t *testing.T) {
314
315 for _, f := range badCompilerFlags {
316 if err := checkCompilerFlagsForInternalLink("test", "test", f); err == nil {
317 t.Errorf("missing error for %q", f)
318 }
319 }
320
321
322
323 for _, f := range goodCompilerFlags {
324 foundLTO := false
325 for _, s := range f {
326 if strings.Contains(s, "-flto") {
327 foundLTO = true
328 }
329 }
330 if err := checkCompilerFlagsForInternalLink("test", "test", f); err != nil {
331
332 if !foundLTO {
333 t.Errorf("unexpected error for %q: %v", f, err)
334 }
335 } else {
336
337 if foundLTO {
338 t.Errorf("missing error for %q: %v", f, err)
339 }
340 }
341 }
342 }
343
View as plain text